Update to NullAway 0.12.15 and fix new warnings #36054
Open
+29
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @sdeleuze |
spring-projects-issues
added
the
status: waiting-for-triage
msridhar
force-pushed
the
nullaway-0.12.15-fixes
branch
from
1ac5243 to
b39f321
Compare
Signed-off-by: Manu Sridharan <msridhar@gmail.com>
msridhar
force-pushed
the
nullaway-0.12.15-fixes
branch
from
b39f321 to
b4ec0ad
Compare
Member
|
I don't think we should upgrade just yet even if this works for framework, see spring-gradle-plugins/nullability-plugin#25 |
Contributor
Author
|
Hi @snicoll thanks, I commented on the NullAway issue you opened. It might be reasonable to change the nullability-plugin to not enable For context, I'm interested in getting Spring Framework upgraded to NullAway 0.12.15 since we use it as an integration test for NullAway, and that integration test has been failing due to the new warnings that this PR fixes. Nothing critical, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new warnings are a consequence of uber/NullAway#1371, which better detections annotations on type arguments in return types. Fortunately, the fixes are straightforward. Note that writing
@Nullable Voidis required by JSpecify (see jspecify/jspecify#51). This is not yet checked exhaustively by NullAway, but some instances were caught here.